Skip to content

Polish gallery sort: standard icon, native menu with checkmarks#769

Merged
theospears merged 2 commits intomasterfrom
claude/polish-sort-ui-HtujR
Apr 26, 2026
Merged

Polish gallery sort: standard icon, native menu with checkmarks#769
theospears merged 2 commits intomasterfrom
claude/polish-sort-ui-HtujR

Conversation

@theospears
Copy link
Copy Markdown
Collaborator

@theospears theospears commented Apr 26, 2026

Summary

  • Replace text.line.magnify icon with arrow.up.arrow.down — the standard iOS sort glyph
  • Replace UIAlertController action sheet (which used --> ASCII prefix to mark the selected option) with a native UIMenu that shows a proper checkmark via state: .on
  • Uses UIDeferredMenuElement.uncached so the menu rebuilds on each open, always reflecting the current selection

Follows up on #616.

Before After
text.line.magnify icon arrow.up.arrow.down icon
Action sheet with --> Urgency Native menu with ✓ Urgency

Test plan

  • Verified in simulator (iPhone 17 Pro, iOS 26.4)
  • Tap sort icon — menu appears with "Sort by" header and checkmark on current selection
  • Select a different sort — gallery reorders, reopening menu shows checkmark moved

🤖 Generated with Claude Code

- Use arrow.up.arrow.down (the conventional iOS sort glyph) instead of
  text.line.magnify, which reads as a search/zoom affordance.
- Replace the action sheet (which marked the active option with an ASCII
  "--> " prefix) with a UIMenu using .singleSelection. The current sort
  now renders with a native checkmark. UIDeferredMenuElement.uncached
  rebuilds the menu on each open so the indicator always reflects the
  latest selection.

https://claude.ai/code/session_01RRD9boKycR1JgTi9NkZKRF
@theospears theospears requested a review from a team as a code owner April 26, 2026 04:26
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@theospears theospears merged commit c33f256 into master Apr 26, 2026
6 checks passed
@theospears theospears deleted the claude/polish-sort-ui-HtujR branch April 26, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants